Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed behavior so now symbol instances are renamed to the last portion of a symbol master name after the "/" #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fbmore
Copy link

@fbmore fbmore commented Mar 9, 2018

@sonburn I apologize for any mess I might have created. Ideally we'd give users the ability to choose the desired behavior and choose "The / Full / Name" or simply "Name".

We can remove if we only want one of the two behaviours but I wanted my intentions to be obvious.
I'll reach out via Slack too :)

image

What do you think?

Copy link
Author

@fbmore fbmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sonburn since you are releasing an update would you mind including the feature suggested in this pull request? “Rename all instances to string after last “/“ :) thank you!

@sonburn
Copy link
Owner

sonburn commented May 8, 2018

It's a good idea and is in line with some other feature request(s) about some control over the name during the process, but the way it's implemented needs to be different. What you are wanting to achieve should actually be available for all flavors of the plugin, not just the at the Page level as you had implemented.

As the plugin is headless right now, a new option should be added to provide an interface to run the plugin in one of the existing methods, but with additional options for controls over the name.

I'll start working on this for an update to the plugin!

@fbmore
Copy link
Author

fbmore commented May 8, 2018

@sonburn yes! My coding skills are pretty basic. I have been using this modified version but I’d love to have more control over the scope (selection / symbols within selected artboards / instances of specific symbol across pages / all instances of all symbols)! - love your plugin!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants