Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #264: restore v version prefix #267

Merged
merged 2 commits into from
Jun 2, 2022
Merged

fix #264: restore v version prefix #267

merged 2 commits into from
Jun 2, 2022

Conversation

bhamail
Copy link
Contributor

@bhamail bhamail commented Jun 2, 2022

OSS Index used to require the version for golang components to not have a "v" prefix. This has changed, so now both OSS Index and IQ are happy with golang components who's version string is prefixed with a "v".

This PR removes the code that removed the "v".

cc @bhamail / @DarthHater

Copy link
Member

@DarthHater DarthHater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice sensible changes that seem to remove something I really hated doing to begin with.

@bhamail bhamail merged commit 281866d into main Jun 2, 2022
@bhamail bhamail deleted the v_version_prefix branch June 2, 2022 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update version string to have "v" prefix expected by OSSIndex
2 participants