Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize version when using go install #266

Merged

Conversation

jmdacruz
Copy link
Contributor

This pull request makes the following changes:

  • fixes issue with unnormalized version tags when installing via go install (e.g., v1.1.1 vs 1.1.1)

It relates to the following issue #s:

cc @bhamail / @DarthHater

Copy link
Contributor

@bhamail bhamail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
Looks good. Great to see the unit test!

@bhamail bhamail merged commit 93517cd into sonatype-nexus-community:main May 27, 2022
@jmdacruz
Copy link
Contributor Author

I'll wait for a new tag to be added to the repo, so that I can properly test the installation with go install

@jmdacruz
Copy link
Contributor Author

confirmed that this is working fine after installing with go install github.com/sonatype-nexus-community/nancy@v1.0.35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants