Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for base path of DB cache to be set #249

Merged
merged 2 commits into from
Sep 22, 2021
Merged

Allow for base path of DB cache to be set #249

merged 2 commits into from
Sep 22, 2021

Conversation

DarthHater
Copy link
Member

This should address #216

This pull request makes the following changes:

  • Upgrades go-sona-types to 0.1.2
  • Adds a db-cache-path flag
  • Sets db-cache-path when setting up OSS Index
  • Updates README, etc...

It relates to the following issue #s:

cc @bhamail / @DarthHater

bhamail
bhamail approved these changes Sep 22, 2021
View reviewed changes
Copy link
Contributor

@bhamail bhamail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. As soon as CI is happy, will push release buttons again.

@bhamail bhamail merged commit 533b797 into main Sep 22, 2021
@bhamail bhamail deleted the AllowBasePathForCacheToBeConfigured branch September 22, 2021 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhamail bhamail bhamail approved these changes

@zendern zendern Awaiting requested review from zendern

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Configurable cache directory
2 participants
@DarthHater @bhamail