make --clean-cache available as root command
#169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fic to ossi or iq.
zendern
approved these changes
Aug 18, 2020
bhamail
added a commit
that referenced
this pull request
Aug 19, 2020
bhamail
added a commit
that referenced
this pull request
Aug 27, 2020
…ial release (#161) * Cobra/Viper CLI. * Goodbye go.sum old friend You were fine to start but newer better things came along. We will never forget your contributions to the cause. * fix missing -p flag, document --loud flag * Make some packages internal (#163) * remove types that migrated to go-sona-types library (#164) * store config using nested yaml (ossi.yadda, iq.yadda). * separate `sleuth` command for 'oss index' (#165) new sub command named `sleuth` for running nancy against OSS Index. * make `--clean-cache` available as root command, since it is not specific to ossi or iq. (#169) * Latest dependencies, remove obsolete 'replace' directives (#173) * Use goreleaser to build native linux installers (#175) Co-authored-by: Nathan Zender <github@nathanzender.com> Co-authored-by: Jeffry Hesse <5544326+DarthHater@users.noreply.github.com>
zendern
added a commit
to zendern/nancy
that referenced
this pull request
Apr 16, 2021
…ial release (sonatype-nexus-community#161) * Cobra/Viper CLI. * Goodbye go.sum old friend You were fine to start but newer better things came along. We will never forget your contributions to the cause. * fix missing -p flag, document --loud flag * Make some packages internal (sonatype-nexus-community#163) * remove types that migrated to go-sona-types library (sonatype-nexus-community#164) * store config using nested yaml (ossi.yadda, iq.yadda). * separate `sleuth` command for 'oss index' (sonatype-nexus-community#165) new sub command named `sleuth` for running nancy against OSS Index. * make `--clean-cache` available as root command, since it is not specific to ossi or iq. (sonatype-nexus-community#169) * Latest dependencies, remove obsolete 'replace' directives (sonatype-nexus-community#173) * Use goreleaser to build native linux installers (sonatype-nexus-community#175) Co-authored-by: Nathan Zender <github@nathanzender.com> Co-authored-by: Jeffry Hesse <5544326+DarthHater@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having the
--clean-cacheonly available viasleuthis awkward because clearing the cache is not specific to thesleuthcommand. Clearing the cache would also affect theiqcommand - in that a call to ossi would always occur after the cache is cleared.When the clear impl was only in the
sleuthcommand, there was a bug that allowed a CLI call like:nancy -cto appear to succeed, but the cache was not actually cleared. This was because the-cwas valid everywhere (a "PersistentFlag" in Cobra lingo), but was ONLY implemented in thesleuthcall stack.This PR makes the
--clean-cacheoccur as part of the rootCmd.cc @bhamail / @DarthHater