make --clean-cache
available as root command
#169
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having the
--clean-cache
only available viasleuth
is awkward because clearing the cache is not specific to thesleuth
command. Clearing the cache would also affect theiq
command - in that a call to ossi would always occur after the cache is cleared.When the clear impl was only in the
sleuth
command, there was a bug that allowed a CLI call like:nancy -c
to appear to succeed, but the cache was not actually cleared. This was because the-c
was valid everywhere (a "PersistentFlag" in Cobra lingo), but was ONLY implemented in thesleuth
call stack.This PR makes the
--clean-cache
occur as part of the rootCmd.cc @bhamail / @DarthHater