Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

semantic-release versioning configuration - for pypyproject.toml #149

Merged
merged 1 commit into from
Dec 8, 2023
Merged

semantic-release versioning configuration - for pypyproject.toml #149

merged 1 commit into from
Dec 8, 2023

Conversation

cshaley
Copy link
Contributor

@cshaley cshaley commented Dec 8, 2023

#148

I'm still not certain semantic-release is incrementing the version in pyproject.toml (which I thought it used to do).

This should do it per the python-semantic-release docs. https://python-semantic-release.readthedocs.io/en/latest/configuration.html

It relates to the following issue #s:

cc @bhamail / @DarthHater

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@cshaley cshaley mentioned this pull request Dec 8, 2023
Merged
bhamail
bhamail approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@bhamail bhamail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@bhamail bhamail merged commit 08f6c2f into sonatype-nexus-community:main Dec 8, 2023
2 checks passed
@bhamail
Copy link
Contributor

bhamail commented Dec 8, 2023

Hm, doesn't look like it is actually updating pyproject.toml with the next version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhamail bhamail bhamail approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cshaley @bhamail