-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove compatibility with PHP 7.3 #340
Conversation
this is problematic, since we add rector and upgrade the code for php 7.4, but the composer.json still showed us 7.3, there was not a build with 7.3 but we didn't notice until someone opened a PR againts SonataAdminBundle 3.x, which supports php 7.3: |
Indeed the 1.14 and 1.15 will create an issue with php 7.3... What should we do ? The only idea I have so far is
WDYT @jordisala1991 ? (Or doing this for 1.15.0 might be enough) |
We can do a 1.15.1 release from the #341 branch (without merging) in order to fix the 7.3 compatibility. @jordisala1991 |
This reverts commit 449ecf6.
Subject
I am targeting this branch, because this is BC.