Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove compatibility with PHP 7.3 #340

Merged
merged 1 commit into from
May 14, 2022
Merged

Conversation

jordisala1991
Copy link
Member

@jordisala1991 jordisala1991 commented May 13, 2022

Subject

I am targeting this branch, because this is BC.

@jordisala1991
Copy link
Member Author

this is problematic, since we add rector and upgrade the code for php 7.4, but the composer.json still showed us 7.3, there was not a build with 7.3 but we didn't notice until someone opened a PR againts SonataAdminBundle 3.x, which supports php 7.3:
sonata-project/SonataAdminBundle#7818

@jordisala1991 jordisala1991 requested review from VincentLanglet and a team May 13, 2022 15:21
@VincentLanglet
Copy link
Member

VincentLanglet commented May 13, 2022

this is problematic, since we add rector and upgrade the code for php 7.4, but the composer.json still showed us 7.3, there was not a build with 7.3 but we didn't notice until someone opened a PR againts SonataAdminBundle 3.x, which supports php 7.3: sonata-project/SonataAdminBundle#7818

Indeed the 1.14 and 1.15 will create an issue with php 7.3...

What should we do ? The only idea I have so far is

  • Starting a branch from 1.14.0
  • Reverting the rector changes
  • Releasing this as 1.14.1
  • Starting a branch from 1.15.0
  • Reverting the rector changes
  • Releasing this as 1.15.1

WDYT @jordisala1991 ?

(Or doing this for 1.15.0 might be enough)

@VincentLanglet
Copy link
Member

We can do a 1.15.1 release from the #341 branch (without merging) in order to fix the 7.3 compatibility. @jordisala1991

@VincentLanglet VincentLanglet merged commit 449ecf6 into 1.x May 14, 2022
@VincentLanglet VincentLanglet deleted the jordisala1991-patch-1 branch May 14, 2022 08:03
VincentLanglet added a commit that referenced this pull request May 14, 2022
VincentLanglet added a commit that referenced this pull request May 14, 2022
jordisala1991 added a commit that referenced this pull request May 14, 2022
jordisala1991 added a commit that referenced this pull request May 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants