-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add webpack and missing datepicker scripts #329
Add webpack and missing datepicker scripts #329
Conversation
Companion PR for SonataAdminBundle: sonata-project/SonataAdminBundle#7809 |
So, with the current config, everything works, jQuery is completely shared across SonataAdmin and form extensions, and we moved everything related to date picker here. There is only one part that is still on SonataAdminBundle:
When we update the date time picker library, this won't be necessary. what should we do about it? |
Another thing that we should ensure, is that this move does not require a new major of AdminBundle, to do so, we might add this PR to 1.x instead. |
Oh I misunderstood sonata-project/SonataAdminBundle#7809, We have two solutions
I don't think this PR is a BC break, so we might do it in 1.x indeed ; this would be better. |
b6dc581
to
c0792f1
Compare
I think adding it to 1.x make more sense, rebased. |
This one will require a minor release, and then we can work on the integration with the admin bundle |
Subject
I am targeting this branch, because this is BC.
Changelog