Recommend Prophecy for test doubles creation #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Since phpunit 4.5, phpunit requires and [integrates](https://phpunit.de/manual/current/en/test-doubles.html#test-doubles.prophecy) | ||
| the [phpspec/prophecy](https://github.com/phpspec/prophecy). | ||
| Historically, Sonata has been using [the built-in test doubles implementation](https://phpunit.de/manual/current/en/test-doubles.html), | ||
| but has deciding to move to Prophecy, which is more concise than its built-in counterpart is most cases. |
There was a problem hiding this comment.
maybe link to the discussion, if someone is interested?
|
LGTM 👍 |
greg0ire
force-pushed
the
recommend_prophecy
branch
from
6ea1599 to
e1e9a26
Compare
|
@OskarStark : I changed some things, please review it again entirely. |
| @@ -97,6 +97,24 @@ Some rules have to be respected about the test: | |||
| * Most of the time, the test class should have the same name as the targeted class, suffixed by `Test`. | |||
| * The `@expectedException*` annotations are prohibited. Use `PHPUnit_Framework_TestCase::setExpectedException()`. | |||
|
|
|||
| ##### Using test doubles | |||
|
|
|||
| Since phpunit 4.5, phpunit requires and [integrates](https://phpunit.de/manual/current/en/test-doubles.html#test-doubles.prophecy) | |||
There was a problem hiding this comment.
phpunit -> PHPUnit
Because, it is it name. 😛
greg0ire
force-pushed
the
recommend_prophecy
branch
from
e1e9a26 to
1bc94b9
Compare
|
Good job @greg0ire, i like it 👍 |
| @@ -97,6 +97,24 @@ Some rules have to be respected about the test: | |||
| * Most of the time, the test class should have the same name as the targeted class, suffixed by `Test`. | |||
| * The `@expectedException*` annotations are prohibited. Use `PHPUnit_Framework_TestCase::setExpectedException()`. | |||
|
|
|||
| ##### Using test doubles | |||
|
|
|||
| Since version 4.5, PHPUnit requires and [integrates](https://phpunit.de/manual/current/en/test-doubles.html#test-doubles.prophecy) | |||
There was a problem hiding this comment.
should we link to "current" or version 4.5 explicitely?
There was a problem hiding this comment.
We should link to current b/c we are using the current version in our software. No need to link to outdated instructions
core23
approved these changes
Jan 24, 2017
|
LGTM, we should start moving to prophecy 👍 |
|
@soullivaneuh this is 6 months old. What's the deal? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #89.