-
-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change menu label to Breadcrumb menu #696
Conversation
ec18c86
to
57c7477
Compare
@VincentLanglet Can I let the others translation missing it? |
I generally try to add translation thanks to some knowledge, review or translator. In french, |
57c7477
to
f19cc7d
Compare
Ok I asked some guys and They suggested to translate |
Just to have a different icon, what do you think about this one https://fontawesome.com/v5/icons/angle-double-right?s=solid&f=classic or should I keep the same (bars)? |
This icon might be a good idea indeed |
f19cc7d
to
b4cf340
Compare
We're changing from |
hmmm well I was following the sonata admin 4! |
I tested and it works on both way |
But as we require block bundle 4, I guess the user is more or less forced to use sonata 4, don't you? |
We dont force to use sonataAdmin 4. People might use just BlockBundle and SeoBubdle maybe... I dunno where come from this icon, so I dunno if we can use font awesome 5 without a BC break... |
well Ok lets use |
b4cf340
to
ba6e858
Compare
@jordisala1991 could you review please 👀 |
Thank you @eerison |
Adding a name more specific for
breadcrumb menu
I am targeting this branch, because This issue is into this branch.
Changelog
It will sove the issue when we depends the block bundle and seo bundle, like in page bundle