Composer page not showing errors

[jeromeengeln]

Proposition to help with issue "Composer page not showing errors"

See #1495 (comment)

I added some JS to catch json errors and display below form fields.
To make it work I also modified the sonata admin bundle CRUDController :
https://github.com/sonata-project/SonataAdminBundle/blob/eb006137a91100ea416a05818f47172022337912/src/Controller/CRUDController.php#L1356

by adding information about what field trigger an error ($errorsByOrigin) :

protected function handleXmlHttpRequestErrorResponse(Request $request, FormInterface $form): ?JsonResponse
    {
        if ([] === array_intersect(['application/json', '*/*'], $request->getAcceptableContentTypes())) {
            return $this->renderJson([], Response::HTTP_NOT_ACCEPTABLE);
        }

        $errors = [];
        $errorsByOrigin = [];
        foreach ($form->getErrors(true) as $error) {
            $errors[] = $error->getMessage();
            if (!isset($errorsByOrigin[$error->getOrigin()->getName()])) {
                $errorsByOrigin[$error->getOrigin()->getName()] = [];
            }
            $errorsByOrigin[$error->getOrigin()->getName()][] = $error->getMessage();
        }

        return $this->renderJson([
            'result' => 'error',
            'errors' => $errors,
            'errorsByOrigin' => $errorsByOrigin,
        ], Response::HTTP_BAD_REQUEST);
    }

=> this is an example, If you have some ideas to avoid a sonata admin bundle modification.
I hope it can help to move forward with 4.x release

Actual result after submit rss block creation :

[jordisala1991]

I am already working on the SonataAdminBundle part: sonata-project/SonataAdminBundle#7922

You can take a look at how is the output suposed to be. You need to install symfony/serializer to get the nice output.

[eerison]

Thank you for your PR ❤️

But before start to work just comment in #1495, because we can avoid more the on person work in the same thing.

[jordisala1991]

I have pushed some commits to make it work with my PR on admin bundle.

Also have removed usage of more jQuery, and fixed edit. There are some missing pieces:

• take a look at the rest of ajax calls
• edit for some reason doesn't work properly, at some point the save button is disabled and I didn't figure out yet how to enable it again, or who is disabling it.
• when you edit and close + reopen the block, the edit is still in place (I am not sure if that is expected or not, probably here @eerison knows better how it worked on 3.x)

[eerison]

I have pushed some commits to make it work with my PR on admin bundle.

Also have removed usage of more jQuery, and fixed edit. There are some missing pieces:

• take a look at the rest of ajax calls
• edit for some reason doesn't work properly, at some point the save button is disabled and I didn't figure out yet how to enable it again, or who is disabling it.
• when you edit and close + reopen the block, the edit is still in place (I am not sure if that is expected or not, probably here @eerison knows better how it worked on 3.x)

I'll test this branch :)

[eerison]

Hey @jordisala1991 I tested this branch and it's working as expect ❤️

Edit 1: I just saw a small issue when I'm updating But I guess it's fine!

[eerison]

Screen.Recording.2022-09-21.at.10.15.13.mov

if there are some invalid field, the edit button is blocked, and I need to refresh the page to make this work again

[jordisala1991]

Yes, is already detected:

edit for some reason doesn't work properly, at some point the save button is disabled and I didn't figure out yet how to enable it again, or who is disabling it.

from my previous comment.

[jeromeengeln]

I added 2 commit :

• Styling errors as they were in previous version
  
• Remove disabled attribute on submit button if edit form contains errors:
  => I need more time to see if there is an other fix but it seems to come from a bootstrap function

[jordisala1991]

I know where is the disabled behavior, (It is inside sonata), but there are still one thing to understand, why this doesn't happen on creation, I am investigating..

[eerison]

and what is it mean 😄 ?
is it missing something else 👀 ?

[jordisala1991]

and what is it mean 😄 ? is it missing something else 👀 ?

It is ready now, but it misses the admin-bundle PR. That needs to be polished and merged and released before we can merge this one.

[jordisala1991]

2 things missing:

1. browser test for validation error (one simple test that tries to save rss block without setting the url and ensures it shows some errors)
2. release for admin-bundle 4.18.

[eerison]

2 things missing:

1. browser test for validation error (one simple test that tries to save rss block without setting the url and ensures it shows some errors)
2. release for admin-bundle 4.18.

I'm testing!

[eerison]

Screen.Recording.2022-09-28.at.08.37.23.mov

Nice work @jordisala1991 composer page is working quite nice, create and update work as expected ❤️

[jordisala1991]

I just added a browser test to ensure errors are thrown as expected.

Screen.Recording.2022-09-28.at.08.37.23.mov
Nice work @jordisala1991 composer page is working quite nice, create and update work as expected ❤️

Also nice work to @JeromeEngelnAdeliom for starting the PR. :)

[jeromeengeln]

I just added a browser test to ensure errors are thrown as expected.

Screen.Recording.2022-09-28.at.08.37.23.mov
Nice work @jordisala1991 composer page is working quite nice, create and update work as expected ❤️

Also nice work to @JeromeEngelnAdeliom for starting the PR. :)

Thank you @jordisala1991 ;)
I wanted to do at least the test but you already did, you are too fast !
Always a pleasure to start a PR

[VincentLanglet]

Thanks