Not render block that does not exist #1614
Conversation
| @@ -26,7 +26,7 @@ | |||
| "doctrine/doctrine-bundle": "^2.5", | |||
| "doctrine/persistence": "^2.1 || ^3.0", | |||
| "sonata-project/admin-bundle": "^4.15", | |||
| "sonata-project/block-bundle": "^4.16.2", | |||
There was a problem hiding this comment.
It'll be fixed after this PR sonata-project/SonataBlockBundle#1115 pass
There was a problem hiding this comment.
But I need this PR :/
There was a problem hiding this comment.
eerison
force-pushed
the
fix-creash-block-in-page
branch
3 times, most recently
from
b4fd8a3 to
cb75366
Compare
eerison
force-pushed
the
fix-creash-block-in-page
branch
from
cb75366 to
2527c7e
Compare
|
I'll expect what gonna be decided in this PR: sonata-project/SonataBlockBundle#1115 |
|
Hey @VincentLanglet @jordisala1991 |
| return ''; | ||
| } | ||
|
|
||
| return $this->blockHelper->render($block, $options); |
There was a problem hiding this comment.
You can try/catch only the render call.
There was a problem hiding this comment.
Yeah I can do that!
| } | ||
|
|
||
| return $this->blockHelper->render($block, $options); | ||
| } catch (BlockNotFoundException $exception) { |
There was a problem hiding this comment.
Why BlockNotFoundException ?
I thought we introduced a BlockServiceNotFoundException ; you need to catch something else ?
There was a problem hiding this comment.
Yeah it's the old exception I need to change!
Not render block that does not exist
I am targeting this branch, because it requires a fix in sonata block bundle 4.x and it's supported only for page bundle 4.
Issue #1609.
Changelog