Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding notes in Upgrade file #1581

Merged
merged 2 commits into from
Aug 30, 2022
Merged

Conversation

eerison
Copy link
Contributor

@eerison eerison commented Aug 30, 2022

Adding notes in UPGRADE file

@eerison eerison marked this pull request as ready for review August 30, 2022 08:29
@eerison eerison mentioned this pull request Aug 30, 2022
36 tasks
UPGRADE-4.0.md Outdated
@@ -21,6 +21,9 @@ Please be aware the config
```
sonata_block:
context_manager: sonata.page.block.context_manager

sonata_page:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Imo it should have its own section inside the upgrade file, this sections talks about SonataBlockBundle

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check again @jordisala1991

@eerison eerison requested a review from jordisala1991 August 30, 2022 10:41
@VincentLanglet VincentLanglet merged commit 038b7b4 into sonata-project:4.x Aug 30, 2022
@eerison eerison deleted the patch-1 branch August 30, 2022 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants