Problem to create Snapshots #1547
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eerison
commented
Aug 11, 2022
| @@ -45,6 +45,7 @@ public function createBySite(SiteInterface $site): void | |||
| { | |||
| $pages = $this->pageManager->findBy(['site' => $site->getId()]); | |||
|
|
|||
| //I guess it's the problem | |||
| if ($this->snapshotManager instanceof BaseEntityManager) { | |||
There was a problem hiding this comment.
Hey @jordisala1991 do you remember why have you made this change?
f8022f6#diff-ec7c09b3ae7003bdec9a47c70c05ea942e56535b0b83465513e0b1561e0ebdacR48
There was a problem hiding this comment.
I guess it's related with #1535
f8022f6#diff-112198c8b3816a6af7235c0c526ba39544d633700e4538d9ab1fc7e7c770d8f6R38
it's just my guess
There was a problem hiding this comment.
What is the problem you have with snapshot creation? I have test the create snapshots command in a functional way, and they are created for sure. (Might be some edge case not covered by those test).
There was a problem hiding this comment.
WOOPS, this should be an end transation, not sure how is called. ->commit() maybe?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
I am targeting this branch, because {reason}.
Closes #{put_issue_number_here}.
Changelog