Fix build #1480
Merged
Fix build #1480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eerison
reviewed
Jul 22, 2022
| /** | ||
| * @testdox It is returning a block list. | ||
| */ | ||
| public function testLoadPageBlocks(): void | ||
| { | ||
| //Mock | ||
| $managerRegistryMock = $this->createMock(ManagerRegistry::class); |
There was a problem hiding this comment.
Why don't you pass just a mock instead of the service? It should be just a unit test 👀 .
There was a problem hiding this comment.
Because we should not try to mock the orm. There are plenty of test doing it, and it is not a good practice.
There are some reasons for it:
- Mocking the orm just ensure you are calling a bunch of functions, and not if the queries / all the logic works and returns expected results.
- You are forced to mock some internals of the ORM due to final classes. I do not want to mock internal logic of classes because that is very fragile and it will break as soon as the internal class changes without BC break (and again it goes to the point 1 too).
- You should avoid to mock what you don't own, there are a lot of articles about that.
- The test is more complex to read with that mocking.
About doing a kernel test case on the Entity Folder, I do not see any problem about that, we usually don't split test by unit or integration folders. What we do is add a Functional folder for those test that do full application requests and check the generated html.
VincentLanglet
approved these changes
Jul 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had to rewrite a test to use KernelTestCase...
We have a lot of test that mock too much things, we will need to take a look at that at some point (other priorities first).