Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated method related with src/Admin/SharedBlockAdmin #1470

Conversation

eerison
Copy link
Contributor

@eerison eerison commented Jul 18, 2022

Subject

I am targeting this branch, because {reason}.

Closes #{put_issue_number_here}.

Changelog

### Added
- Added some `Class::newMethod()` to do great stuff.

### Changed

### Deprecated

### Removed

### Fixed

### Security

@eerison eerison changed the base branch from 3.x to 4.x July 18, 2022 09:00
@eerison eerison mentioned this pull request Jul 18, 2022
17 tasks
@eerison
Copy link
Contributor Author

eerison commented Jul 18, 2022

Hey @VincentLanglet do you have any idea, how SharedBlockAdmin defines baseRoutePattern ?

I didn't find out here it's set!

@eerison eerison changed the title Feature/solve get base route pattern deprecation Remove deprecated method related with src/Admin/SharedBlockAdmin Jul 18, 2022
@VincentLanglet
Copy link
Member

See #1417 (comment). This will be done directly when bumping sonata to 4.x.

But we need sonata-project/SonataAdminBundle#7867 first

@eerison
Copy link
Contributor Author

eerison commented Jul 18, 2022

After sonata-project/SonataAdminBundle#7867 pass I'll check if this PR is useful yet.

@eerison eerison closed this Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants