Remove deprecated getConnection #1462
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think @Hanmac is working on this. By changing the sql to dql, we wont need the getConnection call |
|
yeah it should be fixed by #1446 |
Amin-Hosseini
changed the title
|
Hey @Amin-Hosseini there are others depreciations in #1417 , you could get other one, please just put a comment, just to make sure that anyone is working in the deprecation that you chose |
|
Hi @eerison, yeah sure. Thank you 🙂 |
|
Fixed by the @Hanmac pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove deprecated getConnection #1417
I am targeting this branch, because "BaseEntityManager::getConnection" method is deprecated since sonata-project/sonata-doctrine-extensions 1.15 and we need to update the code for the next major
Closes #1417
Changelog