Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update getMediaBuilder Admin #2402

Merged
merged 8 commits into from
Jul 28, 2023
Merged

Update getMediaBuilder Admin #2402

merged 8 commits into from
Jul 28, 2023

Conversation

Elkawaie
Copy link
Contributor

@Elkawaie Elkawaie commented Jun 13, 2023 •
edited by VincentLanglet
Loading

Subject

I am targeting this branch, because compatibility SonataPageBundle and SonataMediaBundle.

Closes #2401 .

Changelog

### Changed
- Resole "Admin has no subject" error from the getMediaBuilder

@Elkawaie
Copy link
Contributor Author

Elkawaie commented Jun 23, 2023 •
edited
Loading

Hello @jordisala1991, sorry for this delay.
It should work now, what do you think?

@Elkawaie Elkawaie changed the title add association Admin Update getMediaBuilder Admin Jun 23, 2023
@VincentLanglet
Copy link
Member

Sorry for the delay ; Static analysis errors are false positive, I'm on it

@VincentLanglet
Copy link
Member

Can you rebase the PR @Elkawaie ?

@Elkawaie
Copy link
Contributor Author

Sorry long weekend of computer disconnection for me.
Is done @VincentLanglet can you check again ? :)

@VincentLanglet
Copy link
Member

Ignore the PHPStan build failure ; but you need to fix https://github.com/sonata-project/SonataMediaBundle/actions/runs/5642907182/job/15283837758?pr=2402

@Elkawaie

@Elkawaie
Copy link
Contributor Author

is done @VincentLanglet 🤞

@Elkawaie @VincentLanglet
Support nullable
b36f9a2 
Co-authored-by: Vincent Langlet <VincentLanglet@users.noreply.github.com>
@Elkawaie
Copy link
Contributor Author

Thank you @VincentLanglet @jordisala1991 for supporting my first contribution. Ping me if needed some action again 🙏

@VincentLanglet VincentLanglet merged commit 9051e2c into sonata-project:4.x Jul 28, 2023
@VincentLanglet VincentLanglet mentioned this pull request Jan 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jordisala1991 jordisala1991 jordisala1991 approved these changes

@VincentLanglet VincentLanglet VincentLanglet approved these changes

Assignees
No one assigned
Labels
patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Admin has no subject
3 participants
@Elkawaie @VincentLanglet @jordisala1991