Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DevKit updates for 3.x branch #1944

Merged
merged 3 commits into from
Mar 25, 2021
Merged

DevKit updates for 3.x branch #1944

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a7eea3f
DevKit updates
SonataCI Mar 24, 2021
b280178
DevKit updates
SonataCI Mar 25, 2021
a27e18e
DevKit updates
SonataCI Mar 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,19 +42,19 @@ jobs:
dependencies: lowest
allowed-to-fail: false
variant: normal
- php-version: '7.4'
- php-version: '8.0'
dependencies: highest
allowed-to-fail: false
variant: 'symfony/symfony:"4.4.*"'
- php-version: '7.4'
- php-version: '8.0'
dependencies: highest
allowed-to-fail: false
variant: 'sonata-project/admin-bundle:"3.*"'
- php-version: '7.4'
- php-version: '8.0'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we should drop imagine 0.7?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this can be done in a minor release 👍🏻

dependencies: highest
allowed-to-fail: false
variant: 'imagine/imagine:"0.7.*"'
- php-version: '7.4'
- php-version: '8.0'
dependencies: highest
allowed-to-fail: false
variant: 'imagine/imagine:"1.*"'
Expand Down