Fix error on YouTube media creation #1847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tambait
force-pushed
the
fix-issue-1804
branch
from
586d89a to
5f439f1
Compare
|
I initially made changes along proposal in #1804 which solved the issue but tests for PHP 7.3 & 7.4 were failing. Since I wasn't sure how to adapt test code, I tried with different approach but now PHP 8.0 test is failing. |
|
Dont worry about php 8, this build needs some work before it can pass. |
When looking at checks made somewhere else in the code, they check for instanceof \SplFileInfo, instead of File (which extends \SplFileInfo) |
tambait
force-pushed
the
fix-issue-1804
branch
from
5f439f1 to
ce66ac2
Compare
VincentLanglet
previously approved these changes
Oct 22, 2020
tambait
force-pushed
the
fix-issue-1804
branch
from
ce66ac2 to
afaeffa
Compare
VincentLanglet
approved these changes
Oct 22, 2020
OskarStark
approved these changes
Oct 23, 2020
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
I am targeting this branch because this is a bug fix.
Closes #1804
Changelog