Add support for Twig 3

[jorrit]

Subject

It seems Twig 3 support can be enabled without other changes.

I am targeting this branch, because using Twig 3 is backwards compatible.

Changelog

### Added
- Added support for Twig 3.

TODO:

• Update nelmio/api-doc-bundle to ^3.0 (perhaps wait until Update conflict constraint for "nelmio/api-doc-bundle" in order to allow version 3 #1801 is merged).
• Check if changes in the Twig/Node directory work in practice.

[jorrit]

For some reason the tests fail locally because \Sonata\Form\Validator\ErrorElement is final and some tests in FileProviderTest try to mock it. I have no idea why it works in GitHub actions.

[phansys]

twig/twig:3 is not being installed: https://github.com/sonata-project/SonataMediaBundle/pull/1807/checks?check_run_id=1123657456#step:12:238.

[franmomu]

By the way:

$ composer why-not twig/twig 3
sonata-project/formatter-bundle  4.2.0  requires  twig/twig (^2.12.1)

[jorrit]

Sorry, what a rookie mistake. Tomorrow I'll see if the formatter bundle can be upgraded.

[franmomu]

Sorry, what a rookie mistake. Tomorrow I'll see if the formatter bundle can be upgraded.

It's not rookie at all, I didn't know about that command until I saw it to @greg0ire

[jorrit]

FormatterBundle requires the MediaBundle so there is a circular reference of two bundles requiring twig 2. What's the best approach here? Update one, check the other and then go back and check the first again?

[jordisala1991]

Do you know if the media-bundle has any dependency with formatter-bundle? I mean, does it have: use Sonata\Formatter....; or on services.xml?

[jorrit]

@jordisala1991: no, there is no code reference. In fact, it seems the only place the Formatter Bundle is referenced is to load an additional configuration file called formatter.xml, which loads a Twig extension. This Twig extension is needed by the Formatter Bundle but has no dependency on it.

I have removed the dev dependency and Twig 3 is installed now. I have fixed a breakage, but it seems nelmio/api-doc-bundle has to be updated too. This is quite some work: https://github.com/nelmio/NelmioApiDocBundle/blob/master/UPGRADE-3.0.md

[core23]

BC Break alert

[jorrit]

Does this matter? I don't think anyone (should) rely on MediaExtension implements InitRuntimeInterface or not.

[phansys]

Does this matter? I don't think anyone (should) rely on MediaExtension implements InitRuntimeInterface or not.

Think about the result if a user is declaring a method (argument or return) with the removed interface. Does this matter?

[jorrit]

InitRuntimeInterface is part of Twig 2 and removed in Twig 3. If the user refers to InitRuntimeInterface they can't upgrade to Twig 3.

[phansys]

AFAIK, we aren't dropping the support for twig/twig:2 in this PR.

[jorrit]

That's true. The functionality of InitRuntimeInterface can be implemented diffently in a way that works both in Twig 2 and 3. InitRuntimeInterface is only used to inject the Twig\Environment and I've moved that to the classes in Twig\Node.

[jordisala1991]

This PR should target master branch if it contains BC breaks.

[jorrit]

This PR should target master branch if it contains BC breaks.

Perhaps I can do something with interface_exists()? Anyway, #1801 needs to be finished first.

[github-actions]

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.