Catch possible null value error in ModelFilter #1800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
core23
requested review from
jordisala1991 and
VincentLanglet
and removed request for
jordisala1991
src/Filter/ModelFilter.php
Outdated
| @@ -147,6 +147,10 @@ private function buildInExpression(ProxyQueryInterface $query, string $alias, Fi | |||
| $orX = $queryBuilder->expr()->orX(); | |||
|
|
|||
| foreach ($data->getValue() as $value) { | |||
| if (null === $value) { | |||
There was a problem hiding this comment.
Wouldn't even safer to user if (!\is_object($value)) { ?
|
You can rebase 4.x to fix the ci |
|
Done |
|
Thanks, I dont have a computer until next week. It's on my todo to review/merge/release this |
VincentLanglet
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
I am targeting this branch, because is a patch.
Changelog
Got the error when using the
ModelFilterin combination with aModelAutocompleteType.The error might show up if you bookmark a link (e.g. /list?filter[user][value]=entityID123) and you than remove the referenced entity. The
hasValuecheck passes, because you provide a valid value, but there is no entity so you receive a null error.