-
-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for collection removal without triggering validation #1737
Add tests for collection removal without triggering validation #1737
Conversation
a517f15
to
3dbc123
Compare
Once the PR is merged and released, this should not fail (It will require bump requirements to not fail on lower deps @VincentLanglet |
With this we have tests for the CollectionType, case where we fail validation (not removing an item) and case where the validation is not executing because even it the collection item is not valid, it is also removed. |
I would consider bumping a dependency minor as pedantic, no ? |
Not sure about that TBH , first I tagged as pedantic, but since it can affect users of this package, I changed it to minor. |
Developper doesn't need any notification since composer will do the version resolution. |
Subject
I am targeting this branch, because this is BC.
Changelog