Fix batch delete on entities with json columns (PostgreSQL) #1695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this fixes your issue @eerison ? What do you think about it @VincentLanglet ? The code has the distinct since a commit 8 years ago. Can this cause trouble in some edge cases? I do not know in which cases I would want to do a distinct here. |
Hey @jordisala1991 I tested your Branch and it works ❤️ |
eerison
previously approved these changes
Sep 28, 2022
jordisala1991
changed the title
36 tasks
eerison
approved these changes
Sep 28, 2022
3 tasks
VincentLanglet
approved these changes
Sep 28, 2022
|
Should we release this as patch or minor? @VincentLanglet |
|
Maybe safer as a minor ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
I am targeting this branch, because this is BC.
Closes issues related with batch delete on entities with json columns. Will still need to remove the jsonb from media-bundle to avoid problem for non postgres users.
Changelog