Fix binding arbitrary params as part of a value expression in the query filter at Filter::applyWhere() with PostgreSQL
#1439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phansys
force-pushed
the
pr_1431
branch
2 times, most recently
from
d156f19 to
d3964f6
Compare
phansys
force-pushed
the
pr_1431
branch
3 times, most recently
from
b465938 to
dfefcc9
Compare
phansys
changed the title
Filter::applyWhere() with PostgreSQL
VincentLanglet
previously approved these changes
May 16, 2021
src/Filter/Filter.php
Outdated
| @@ -204,8 +205,7 @@ private function addOrParameter(BaseProxyQueryInterface $query, $parameter): voi | |||
|
|
|||
| if (null === $groupName) { | |||
| // Add the ":sonata_admin_datagrid_filter_query_marker" parameter as marker for the `Orx` expression. | |||
There was a problem hiding this comment.
Should the comment be updated ?
There was a problem hiding this comment.
Yes. Updated.
Thank you.
VincentLanglet
approved these changes
May 17, 2021
franmomu
approved these changes
May 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
Fix binding arbitrary params as part of a value expression in the query filter at
Filter::applyWhere()with PostgreSQL.I am targeting this branch, because this change respects BC.
Closes #1389.
Changelog