Fix compatibility with SonataAdmin and add final #1438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentLanglet
commented
May 3, 2021
| @@ -47,8 +47,8 @@ public function countResults(): int | |||
| public function init(): void | |||
| { | |||
| $query = $this->getQuery(); | |||
| if (null === $query) { | |||
| throw new \LogicException('The pager need a query to be initialised'); | |||
| if (!$query instanceof ProxyQueryInterface) { | |||
There was a problem hiding this comment.
This was changed recently.
But we still need the execute method to return a countable value.
| @@ -98,14 +98,7 @@ public function filter(ProxyQueryInterface $query, string $alias, string $field, | |||
| $query->getQueryBuilder()->setParameter($parameterName, $value, $this->getParameterType($value)); | |||
| } | |||
|
|
|||
| public function getDefaultOptions(): array | |||
There was a problem hiding this comment.
This method is always overriden.
| public function getRenderSettings(): array | ||
| { | ||
| return [DefaultType::class, [ | ||
| 'operator_type' => $this->getOption('operator_type'), | ||
| 'operator_options' => $this->getOption('operator_options'), | ||
| 'field_type' => $this->getFieldType(), | ||
| 'field_options' => $this->getFieldOptions(), | ||
| 'field_options' => [ |
There was a problem hiding this comment.
I didn't kept the choices option.
I think it's not used. It's supposed to be used this way
'choices' => [
'choices' => [...],
],
The syntax is so weird I assume it wasn't used this way.
But I wonder if I shouldn't add choice_translation_domain => false in the default values.
jordisala1991
approved these changes
May 4, 2021
dmaicher
approved these changes
May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog