-
-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop using SonataAdmin config in doctrineORMAdmin #1427
Conversation
I need to wait for sonata-project/SonataAdminBundle#7127 And, @dmaicher, I need to this AFTER the |
5e618d3
to
76a4b5b
Compare
Then we should give https://github.com/sonata-project/SonataDoctrineORMAdminBundle/blob/3.x/src/SonataDoctrineORMAdminBundle.php#L30 a lower priority than 0 so it comes after https://github.com/sonata-project/SonataAdminBundle/blob/3.x/src/SonataAdminBundle.php#L55. Like $container->addCompilerPass(new AddTemplatesCompilerPass(), PassConfig::TYPE_BEFORE_OPTIMIZATION, -1); |
Need SonataAdmin 3.98.2 |
->arrayNode('filter') | ||
->setDeprecated('The "%node%" option is deprecated since sonata-project/admin-bundle 3.x.') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
package name should be changed to the orm bundle, same above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except for the deprecation message namings mentioned by @jordisala1991
And we need to release this soon as without it admin release 3.98.2 is a bit broken for ORM users
Subject
I am targeting this branch, because BC.
Changelog