Add support for \DateTimeImmutable at AbstractDateFilter::filter()
#1190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
reviewed
Nov 7, 2020
phansys
force-pushed
the
date_range_immutable
branch
from
7add919 to
804501f
Compare
VincentLanglet
previously approved these changes
Nov 7, 2020
phansys
force-pushed
the
date_range_immutable
branch
from
804501f to
eb5ecee
Compare
franmomu
previously approved these changes
Nov 7, 2020
VincentLanglet
previously approved these changes
Nov 7, 2020
|
You will have conflict with #1189 |
Since #1189 is a bugfix, I'd prefer to merge that PR first. |
greg0ire
previously approved these changes
Nov 7, 2020
Done |
|
Could you please rebase your PR and fix merge conflicts? |
phansys
dismissed stale reviews from greg0ire, VincentLanglet, and franmomu
via
e809bb1
phansys
force-pushed
the
date_range_immutable
branch
from
eb5ecee to
e809bb1
Compare
franmomu
approved these changes
Nov 8, 2020
VincentLanglet
approved these changes
Nov 8, 2020
|
Thanks @phansys! |
phansys
added a commit
to phansys/SonataDoctrineORMAdminBundle
that referenced
this pull request
Nov 9, 2020
phansys
added a commit
to phansys/SonataDoctrineORMAdminBundle
that referenced
this pull request
Nov 12, 2020
phansys
added a commit
to phansys/SonataDoctrineORMAdminBundle
that referenced
this pull request
Nov 13, 2020
franmomu
pushed a commit
that referenced
this pull request
Nov 14, 2020
ggabrovski
pushed a commit
to ggabrovski/SonataDoctrineORMAdminBundle
that referenced
this pull request
Nov 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
Add support for
\DateTimeImmutableatAbstractDateFilter::filter().I am targeting this branch, because this change respects BC.
Changelog