Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use deprecated tag instead of sonata_template_deprecate #1077

Merged
merged 1 commit into from
Jul 15, 2020
Merged

Use deprecated tag instead of sonata_template_deprecate #1077

merged 1 commit into from
Jul 15, 2020

Conversation

franmomu
Copy link
Member

Subject

Ref: sonata-project/SonataDoctrineMongoDBAdminBundle#373

I am targeting this branch, because this is BC.

Changelog

### Changed
- Use `deprecated` tag instead of `sonata_template_deprecate` to not throw unwanted deprecation notices.
### Removed
- Support for Twig 1.x

@franmomu franmomu added the patch label Jul 15, 2020
@franmomu franmomu mentioned this pull request Jul 15, 2020
Merged
@jordisala1991 jordisala1991 requested a review from a team July 15, 2020 19:36
@phansys phansys merged commit 50974bc into sonata-project:3.x Jul 15, 2020
@phansys
Copy link
Member

phansys commented Jul 15, 2020

Thank you @franmomu!

@franmomu franmomu deleted the use_deprecated_tag branch July 16, 2020 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phansys phansys phansys approved these changes

@jordisala1991 jordisala1991 jordisala1991 approved these changes

Assignees
No one assigned
Labels
patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@franmomu @phansys @jordisala1991