-
-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some deprecations about invalid values #1049
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
core23
requested changes
May 25, 2020
core23
previously approved these changes
May 25, 2020
phansys
changed the title
Add some deprecations at
Add some deprecations about invalid values
May 25, 2020
ModelManager
core23
previously approved these changes
May 26, 2020
VincentLanglet
previously approved these changes
May 26, 2020
core23
reviewed
May 26, 2020
core23
previously approved these changes
May 27, 2020
VincentLanglet
previously approved these changes
May 27, 2020
Could you please rebase your PR and fix merge conflicts? |
core23
requested changes
Jun 27, 2020
I've added an entry at |
VincentLanglet
previously approved these changes
Jun 28, 2020
core23
previously approved these changes
Jun 28, 2020
phansys
commented
Jun 28, 2020
VincentLanglet
approved these changes
Jun 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
Add some deprecations at
ModelManager
andFieldDescription
in order to be prepared for the next major.I am targeting this branch, because these changes respect BC.
Changelog
To do