Deprecate the form mapping feature #462

greg0ire · 2017-11-05T19:40:12Z

I am targeting this branch, because this is BC.

Changelog

### Deprecated
- the form mapping feature

To do

Update the documentation (old form names might still be used in there)

Subject

This feature allows users to use form names, just like, you know, before sf 2.8. Needless to say, we need to kill it with fire. It should have been conditionally deprecated as soon as we added support for sf 2.8

OskarStark · 2017-11-06T07:50:06Z

src/DependencyInjection/SonataCoreExtension.php

@@ -116,6 +116,10 @@ public function configureFormFactory(ContainerBuilder $container, array $config)

            return;
        }
+        @trigger_error(


blank line before @trigger_error ?

jlamur · 2017-11-06T07:53:09Z

docs/reference/form_types.rst

-
-DoctrineORMSerializationType
----------------------------
+Sonata\CoreBundle\Form\Type\DoctrineORMSerializationType


What about using short class names instead of FQCN for titles?

Yeah let's do that!

greg0ire · 2017-11-06T14:52:48Z

Build probably failing because of 35a5b84

jlamur · 2017-11-07T11:51:41Z

UPGRADE-3.x.md

@@ -1,6 +1,20 @@
 UPGRADE 3.x
 ===========

+UPGRADE FROM 3.6 to 3.7
+=======================


Please remove this title.

Woops! Done.

is it cached or is the title still available @greg0ire 👀

I must have pushed it again from work or home by accident :P

soullivaneuh · 2017-11-07T12:43:58Z

src/Command/SonataListFormMappingCommand.php

@@ -17,6 +17,9 @@
 use Symfony\Component\Console\Output\OutputInterface;
 use Symfony\Component\HttpKernel\Kernel;

+/**
+ * @deprecated the form mapping feature should be disabled


deprecated since... please follow the format described on the contributing guide.

soullivaneuh · 2017-11-07T12:44:01Z

src/DependencyInjection/Compiler/FormFactoryCompilerPass.php

@@ -14,6 +14,9 @@
 use Symfony\Bundle\FrameworkBundle\DependencyInjection\Compiler\FormPass;
 use Symfony\Component\DependencyInjection\ContainerBuilder;

+/**
+ * @deprecated disable this compiler pass


deprecated since... please follow the format described on the contributing guide.

soullivaneuh · 2017-11-07T12:44:07Z

src/Form/Extension/DependencyInjectionExtension.php

@@ -20,6 +20,8 @@
 /**
 * This proxy class help to keep BC code with < SF2.8 form behavior by restoring
 * the type as a code and not as a class.
+ *
+ * @deprecated use FQCNs instead


deprecated since... please follow the format described on the contributing guide.

soullivaneuh · 2017-11-09T07:45:16Z

@greg0ire It looks you did something wrong with your commit, we still see the old changes. 😕

greg0ire · 2017-11-09T07:55:31Z

@OskarStark @soullivaneuh should be ok now.

OskarStark · 2017-11-13T06:47:50Z

Thank you @greg0ire 👍

greg0ire added the minor label Nov 5, 2017

greg0ire force-pushed the deprecation_legacy_form_pass branch from 7261171 to 2bb6e0b Compare November 5, 2017 19:41

greg0ire mentioned this pull request Nov 5, 2017

Add legacy class to fix old Form compilation pass #456

Closed

greg0ire force-pushed the deprecation_legacy_form_pass branch 4 times, most recently from d254f5f to 1564bcd Compare November 5, 2017 22:20

OskarStark reviewed Nov 6, 2017

View reviewed changes

OskarStark previously approved these changes Nov 6, 2017

View reviewed changes

jlamur reviewed Nov 6, 2017

View reviewed changes

greg0ire dismissed OskarStark’s stale review via 9bba27d November 6, 2017 14:24

greg0ire force-pushed the deprecation_legacy_form_pass branch from 1564bcd to 9bba27d Compare November 6, 2017 14:24

greg0ire requested review from OskarStark and jlamur November 6, 2017 14:24

OskarStark previously approved these changes Nov 6, 2017

View reviewed changes

greg0ire mentioned this pull request Nov 6, 2017

Fixed project paths sonata-project/dev-kit#329

Merged

jlamur suggested changes Nov 7, 2017

View reviewed changes

greg0ire dismissed OskarStark’s stale review via ac6db7c November 7, 2017 12:38

greg0ire force-pushed the deprecation_legacy_form_pass branch from 9bba27d to ac6db7c Compare November 7, 2017 12:38

greg0ire requested a review from jlamur November 7, 2017 12:38

jlamur previously approved these changes Nov 7, 2017

View reviewed changes

soullivaneuh suggested changes Nov 7, 2017

View reviewed changes

greg0ire dismissed jlamur’s stale review via d1d9fd1 November 7, 2017 13:08

greg0ire force-pushed the deprecation_legacy_form_pass branch 2 times, most recently from d1d9fd1 to 2be2783 Compare November 7, 2017 13:09

greg0ire requested a review from soullivaneuh November 7, 2017 13:09

soullivaneuh previously approved these changes Nov 7, 2017

View reviewed changes

OskarStark previously approved these changes Nov 7, 2017

View reviewed changes

greg0ire dismissed OskarStark’s stale review via 4eee7f6 November 8, 2017 07:22

greg0ire dismissed soullivaneuh’s stale review via 4eee7f6 November 8, 2017 07:22

greg0ire force-pushed the deprecation_legacy_form_pass branch from 2be2783 to 4eee7f6 Compare November 8, 2017 07:22

greg0ire requested review from OskarStark, soullivaneuh and jlamur November 9, 2017 07:11

greg0ire force-pushed the deprecation_legacy_form_pass branch 3 times, most recently from 4a926c4 to 82365d6 Compare November 9, 2017 07:54

Deprecate the form mapping feature

2864e01

greg0ire force-pushed the deprecation_legacy_form_pass branch from 82365d6 to 2864e01 Compare November 9, 2017 07:54

OskarStark approved these changes Nov 9, 2017

View reviewed changes

core23 approved these changes Nov 11, 2017

View reviewed changes

OskarStark merged commit 7c72ed8 into sonata-project:3.x Nov 13, 2017

greg0ire deleted the deprecation_legacy_form_pass branch November 26, 2017 14:56

jordisala1991 mentioned this pull request Apr 1, 2018

Not able to decorate a form type service #290

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Deprecate the form mapping feature #462

Deprecate the form mapping feature #462

greg0ire commented Nov 5, 2017 •

edited

Loading

OskarStark Nov 6, 2017

jlamur Nov 6, 2017

greg0ire Nov 6, 2017

greg0ire commented Nov 6, 2017

jlamur Nov 7, 2017

greg0ire Nov 7, 2017

OskarStark Nov 9, 2017

greg0ire Nov 9, 2017

soullivaneuh Nov 7, 2017

soullivaneuh Nov 7, 2017

soullivaneuh Nov 7, 2017

soullivaneuh commented Nov 9, 2017

greg0ire commented Nov 9, 2017

OskarStark commented Nov 13, 2017

Deprecate the form mapping feature #462

Deprecate the form mapping feature #462

Conversation

greg0ire commented Nov 5, 2017 • edited Loading

Changelog

To do

Subject

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

greg0ire commented Nov 6, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

soullivaneuh commented Nov 9, 2017

greg0ire commented Nov 9, 2017

OskarStark commented Nov 13, 2017

greg0ire commented Nov 5, 2017 •

edited

Loading