Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Support PHP 8.0 #653

Merged
merged 1 commit into from
Mar 30, 2021
Merged

Allow Support PHP 8.0 #653

merged 1 commit into from
Mar 30, 2021

Conversation

Yozhef
Copy link
Contributor

@Yozhef Yozhef commented Jan 29, 2021 •
edited
Loading

Changelog

### Added
- Add support for PHP 8.x

@Yozhef
Copy link
Contributor Author

Yozhef commented Jan 29, 2021

Block By sonata-project/SonataDoctrineORMAdminBundle#1285

@Yozhef Yozhef mentioned this pull request Jan 29, 2021
Merged
@jordisala1991
Copy link
Member

This is no longer blocked

@Yozhef Yozhef closed this Feb 24, 2021
@Yozhef Yozhef reopened this Feb 24, 2021
@VincentLanglet
Copy link
Member

Blocked by sonata-project/media-bundle

@Yozhef Yozhef closed this Mar 25, 2021
@Yozhef Yozhef reopened this Mar 25, 2021
@jordisala1991
Copy link
Member

media-bundle is still not released, we need to fix:

sonata-project/SonataMediaBundle#1944 (comment)
sonata-project/SonataMediaBundle#1943

@Yozhef
Copy link
Contributor Author

Yozhef commented Mar 25, 2021 •
edited
Loading

@jordisala1991 maybe I drop imagine 0.7 in dev kit?

@jordisala1991
Copy link
Member

Yes, please, that would be nice :)

@phansys
Copy link
Member

phansys commented Mar 25, 2021

For the changelog, please note that you are adding support for PHP 8.x, not just 8.0.

@jordisala1991 jordisala1991 reopened this Mar 28, 2021
@jordisala1991 jordisala1991 requested a review from a team March 28, 2021 09:56
VincentLanglet
VincentLanglet approved these changes Mar 28, 2021
View reviewed changes
Copy link
Member

@VincentLanglet VincentLanglet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will wait for sonata-project/dev-kit#1386

@VincentLanglet VincentLanglet merged commit e60f0ce into sonata-project:3.x Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VincentLanglet VincentLanglet VincentLanglet approved these changes

@wbloszyk wbloszyk wbloszyk approved these changes

@jordisala1991 jordisala1991 jordisala1991 approved these changes

Assignees
No one assigned
Labels
minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Yozhef @jordisala1991 @VincentLanglet @phansys @wbloszyk