Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu parameter as required #1124

Merged
merged 1 commit into from
Oct 22, 2022
Merged

Conversation

eerison
Copy link
Contributor

@eerison eerison commented Oct 20, 2022

Subject

I am targeting this branch, because {reason}.

Changelog

### Changed
- Changed Menu name settings `required` field from `false` to `true` in `getFormSettingsKeys`

@eerison
Copy link
Contributor Author

eerison commented Oct 20, 2022

This field is required to render Menu

Issue: sonata-project/SonataPageBundle#1495 (comment)

VincentLanglet
VincentLanglet previously approved these changes Oct 20, 2022
@VincentLanglet
Copy link
Member

Can you fix the CI @eerison ?

@eerison
Copy link
Contributor Author

eerison commented Oct 21, 2022

is it missing something 👀 ?

@VincentLanglet
Copy link
Member

is it missing something 👀 ?

time ^^

@jordisala1991 jordisala1991 merged commit 830de1d into sonata-project:4.x Oct 22, 2022
@jordisala1991
Copy link
Member

Thanks @eerison

@eerison eerison deleted the patch-1 branch October 22, 2022 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants