-
-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try #1117
Try #1117
Conversation
I'll give a try in your branch :D |
do you need to update your branch?
|
You should use
|
ops |
It's not catching the exception! |
|
Ok my bad, according to the stack trace, the issue is coming from this line indeed which is coming from this line The exception manager strategy is used but this a TwigRuntimeError because this line is failing Which is trying to render this template which calling again https://github.com/sonata-project/SonataPageBundle/blob/4.x/src/Twig/Extension/PageExtension.php#L194 But why this time the exception is not handled by the strategy manager exception ? |
You said here: #1115 (comment) |
Until this file: PageExtension.php#L194 Our Exception is raised. But when Pass into the https://github.com/sonata-project/SonataPageBundle/blob/4.x/src/Resources/views/Block/block_container.html.twig#L15 twig handle it internally converting to RuntimeException |
But there are other problem! even if I create a new filter checking the twig exception (to skip the exception), and a child block fail, all container is skipped e.g
in this case if some child block broken (like block 2), the whole container block will be skipped |
this exception strategy should receive the exception only, not block and response :/ |
But it shouldn't be raised if the strategy manager is enabled... I mean, what you're saying is that container rendering receive a Twig Error which is not handled by the ExceptionManager.
Does your reproducer is open source ? I'd like to debug |
Ok now it's public https://github.com/nortopecas/norto-system/tree/add_page_bundle_symfony_4_4 |
Thanks, it works fine. Can you explain me how to reproduce the bug ? I suppose I need to create sharedBlock ? And then ? |
Back to sonata page version 3 and add a email (can be more 2 or 3 :D ) block there! |
I'll need more explanation. Which page ? Which url ? if possible I'll need explanation like |
Any reason I'm getting |
hmmm I'm not sure why! maybe you need to run those commands: https://docs.sonata-project.org/projects/SonataPageBundle/en/3.x/reference/getting_started/ |
Thanks. So I made some try, and it's works fine with the config
and the PR #1115 And it only hide the missing block but display others. |
is it showing something for you? for me page is blank 👀 |
It shows all the block which exists and just display nothing for the email block |
can you post here the screenshot how is your blocks and how it looks like in your page? |
it doesn't happen with me, all block are skipped :/ |
and it's blank only if I use debug filter, if I use the filter that check this exception, my page is still broken. |
Do you also use the blockservicéotfound pr ? |
if you mean this PR: #1115
|
It worked fine for me editing https://github.com/nortopecas/norto-system/blob/add_page_bundle_symfony_4_4/config/packages/sonata_page.yaml#L5 and with the 1115 PR. I would recommend you to dump the strategy used in your code/vendor. |
Subject
I am targeting this branch, because {reason}.
Closes #{put_issue_number_here}.
Changelog