[Updated #622] Added configuration option to disable auditing for object associations #644
+77
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/AuditReader.php # src/EventListener/LogRevisionsListener.php
vityachis
changed the title
vityachis
changed the title
VincentLanglet
requested changes
Jan 24, 2025
There was a problem hiding this comment.
As recommended by @phansys in #622 (review)
This PR would need tests for audit results as proof it works without unexpected exceptions.
| @@ -216,7 +216,7 @@ public function find($className, $id, $revision, array $options = []) | |||
| $columnName = $idKeys[0]; | |||
| } elseif (isset($classMetadata->fieldMappings[$idField])) { | |||
| $columnName = self::getMappingColumnNameValue($classMetadata->fieldMappings[$idField]); | |||
| } elseif (isset($classMetadata->associationMappings[$idField]['joinColumns'])) { | |||
| } elseif (!$this->config->areAssociationsDisabled() && isset($classMetadata->associationMappings[$idField]['joinColumns'])) { | |||
There was a problem hiding this comment.
If
isset($classMetadata->associationMappings[$idField]['joinColumns'])
but the associations are disabled you now won't enter in this elseif, so you will go in the else
throw new \RuntimeException('column name not found for'.$idField);
- Is it an expected behavior to get an exception ?
- I would expect a better error message
So I think the logic should be
elseif (isset($classMetadata->associationMappings[$idField]['joinColumns'])) {
if ($this->config->areAssociationsDisabled()) {
// custom behavior or error message
} else {
$columnName = $classMetadata->associationMappings[$idField]['joinColumns'][0]['name'];
}
} else {
...
}
| @@ -113,6 +113,14 @@ public function postGenerateSchemaTable(GenerateSchemaTableEventArgs $eventArgs) | |||
| $revIndexName = $this->config->getRevisionFieldName().'_'.md5($revisionTable->getName()).'_idx'; | |||
| $revisionTable->addIndex([$this->config->getRevisionFieldName()], $revIndexName); | |||
|
|
|||
| if (!$this->config->areForeignKeysDisabled()) { | |||
| $this->createForeignKeys($revisionTable, $revisionsTable); | |||
There was a problem hiding this comment.
You now create ForeignKey before association.
I think it's better to move the foreach ($cm->associationMappings as $associationMapping) { inside a
if (!$this->config->areAssociationsDisabled()) {
to avoid impacts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
Pull request allows you to globally disable building a database scheme, and attempt to audit object relationships.
I am targeting this branch, because it is a new feature.
This is the updated PR #622.
Closes #601.
Changelog