Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker build uses configurable FETCH_VERSION. #28

Merged
merged 1 commit into from
Dec 31, 2023
Merged

Docker build uses configurable FETCH_VERSION. #28

merged 1 commit into from
Dec 31, 2023

Conversation

spoulson
Copy link
Contributor

@spoulson spoulson commented Jan 4, 2023 •
edited
Loading

Build specific versions instead of "latest" by providing an optional FETCH_VERSION build arg.

cd amd64

# Build latest.
docker build -t observium .

# Build 22.12.
docker build -t observium:22.12 --build-arg FETCH_VERSION=22.12 .

FETCH_VERSION may be any version tagged on the published tarball at:
http://www.observium.org/observium-community-${FETCH_VERSION}.tar.gz

Included some config tidy on incorrect indentation.

Closes #29

@spoulson spoulson mentioned this pull request Jan 9, 2023
Closed
abnerrizzi
abnerrizzi approved these changes Nov 10, 2023
View reviewed changes
Copy link

@abnerrizzi abnerrizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

somsakc
somsakc reviewed Dec 31, 2023
View reviewed changes
Copy link
Owner

@somsakc somsakc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's me take a time to review your pull request and assess for other impact. Thank for your contributions..

@somsakc somsakc merged commit c3e0c95 into somsakc:master Dec 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abnerrizzi abnerrizzi abnerrizzi approved these changes

@somsakc somsakc somsakc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Docker build against specified version
3 participants
@spoulson @abnerrizzi @somsakc