Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multiple links support #7

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Gasparonik
Copy link

No description provided.

Onik added 2 commits February 20, 2021 17:25
* @param array|string $linkData
*
* @throws \SomeWork\Symlinks\LinkDirectoryError
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Почему удалены?

{
$links = [];
if (\is_array($linkData)) {
if (\is_array($linkData['links'])) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Так и напрашивается константа

{
$links = [];
if (\is_array($linkData)) {
if (\is_array($linkData['link'])) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Константа!)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Знаю что была нет - но имо стоит уж)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants