-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multiple links support #7
base: master
Are you sure you want to change the base?
Conversation
fix bug single line
* @param array|string $linkData | ||
* | ||
* @throws \SomeWork\Symlinks\LinkDirectoryError |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Почему удалены?
src/Symlinks/SymlinksFactory.php
Outdated
{ | ||
$links = []; | ||
if (\is_array($linkData)) { | ||
if (\is_array($linkData['links'])) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Так и напрашивается константа
src/Symlinks/SymlinksFactory.php
Outdated
{ | ||
$links = []; | ||
if (\is_array($linkData)) { | ||
if (\is_array($linkData['link'])) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Константа!)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Знаю что была нет - но имо стоит уж)
No description provided.