Add PARAMETER_DESCRIPTION and a way to define custom parameters #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arneboe
force-pushed
the
parameter_description
branch
5 times, most recently
from
f4e9039
to
ba6cd79
Compare
arneboe
force-pushed
the
parameter_description
branch
from
ba6cd79
to
7fe3834
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This PR is build on top of #93. Therefore the commits from #93 are also part of this PR. Only the last commit belongs to this PR
This pull request adds support for the PARAMETER_DESCRIPTION parameter which is required by the spec when the SUPPORTED_PARAMETERS parameter is supported.
In addition it adds the
rdm_register_manufacturer_specific_simple()function. This function can be called by the user to add simple parameters. Simple parameters are all parameters that can be handled byrdm_simple_response_cb.I am not sure if
rdm_register_manufacturer_specific_simple()is a good design choice. I added it because I needed a way to test the implementation. An alternative would be to exposerdm_simple_response_cbto the user.This is the last building block that is missing to support manufacturer specific parameters.
Please let me know what you think about this.
A simple example is provided in
RDMManufacturerSpecificParameter.ino.The example does not contain any documentation because I want to wait for your comments on this PR before documenting. I will add documentation once you are fine with the implementation.