-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving to maintained golang-jwt/jwt #35
base: master
Are you sure you want to change the base?
Conversation
Are there any plans to merge this? |
@lazeratops @oxisto - My sincerest apologies! I'm not sure how I didn't see the notification for this PR. I will make it a point to get this reviewed/merged soon! |
Since this will technically be a breaking change, I want to jump onto the latest version of the new repo which is now tagged as v4 (migration guide). That being said, I'd also have to modify this repo's go module version and deps accordingly (e.g. tagging a v3). I think we'll want to enhance this PR a little but it's a great start, thank you @oxisto! |
Yes, going for the |
I finally go around to move this to our current |
Any update on this PR? |
I think we just need to bump the @oxisto / @ksimir - can you confirm if this branch works as intended if you have any production projections you can test this out on? |
Sorry for the late reply, not something in prod but as far as I tested, I didn't see any issue. |
@someone1 Did you have a chance to try it on your side? I think it's safe to bump to v3 and merge. |
@someone1 Sorry to pile on here, but this would be great if you could get this merged 😄 |
@someone1 sorry to bump again this discussion but would you mind merging? |
This PR will move the jwt-go library to the maintained
golang-jwt/jwt
fork of thejwt-go
library, as discussed in http://github.com/dgrijalva/jwt-go/issues/462.