Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving to maintained golang-jwt/jwt #35

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

oxisto
Copy link

@oxisto oxisto commented Jun 9, 2021

This PR will move the jwt-go library to the maintained golang-jwt/jwt fork of the jwt-go library, as discussed in http://github.com/dgrijalva/jwt-go/issues/462.

@lazeratops
Copy link

Are there any plans to merge this?

@someone1
Copy link
Owner

@lazeratops @oxisto - My sincerest apologies! I'm not sure how I didn't see the notification for this PR. I will make it a point to get this reviewed/merged soon!

@someone1
Copy link
Owner

Since this will technically be a breaking change, I want to jump onto the latest version of the new repo which is now tagged as v4 (migration guide).

That being said, I'd also have to modify this repo's go module version and deps accordingly (e.g. tagging a v3).

I think we'll want to enhance this PR a little but it's a great start, thank you @oxisto!

@oxisto
Copy link
Author

oxisto commented Sep 14, 2021

Since this will technically be a breaking change, I want to jump onto the latest version of the new repo which is now tagged as v4 (migration guide).

That being said, I'd also have to modify this repo's go module version and deps accordingly (e.g. tagging a v3).

I think we'll want to enhance this PR a little but it's a great start, thank you @oxisto!

Yes, going for the v4 definitely makes sense.

@oxisto
Copy link
Author

oxisto commented Dec 16, 2021

I finally go around to move this to our current v4 release of jwt-go

@ksimir
Copy link

ksimir commented May 16, 2022

Any update on this PR?

@someone1
Copy link
Owner

I think we just need to bump the go.mod version to v3 so when I merge this and tag it as v3 things work as expected. Also wanted to try this out on some of my projects before merging but I've moved roles since writing this package.

@oxisto / @ksimir - can you confirm if this branch works as intended if you have any production projections you can test this out on?

@ksimir
Copy link

ksimir commented May 31, 2022

Sorry for the late reply, not something in prod but as far as I tested, I didn't see any issue.

@ksimir
Copy link

ksimir commented Jun 7, 2022

@someone1 Did you have a chance to try it on your side? I think it's safe to bump to v3 and merge.

@gmontagu
Copy link

gmontagu commented Jun 9, 2022

@someone1 Sorry to pile on here, but this would be great if you could get this merged 😄

@ksimir
Copy link

ksimir commented Jul 27, 2022

@someone1 sorry to bump again this discussion but would you mind merging?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants