-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add json output #43
Add json output #43
Conversation
b46c8d9
to
f0408ab
Compare
828408f
to
51b7676
Compare
51b7676
to
c7c3f9d
Compare
Hello @vianneybacoup , Thank you for your feedback. |
c7c3f9d
to
6361fd0
Compare
I see that we both had the same issues, I did way too much 'rm *.parquet *.csv' past months haha |
32da7cb
to
8d281cb
Compare
I moved output tests into About json output, I did a POC using arrow (https://github.com/bhagenbourger/Fakelake/tree/poc/use_arrow_for_all_format) because I found interesting to use the same "generator" for all formats. It works but with some limitations as using the same date format for all columns. So definitively, serde-json is more flexible and I keep this implementation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
About arrow for json, I am also wondering if it has poorer performances than serde-json.
Fakelake whole purpose is the speed, so I'd say it should be the focus
Small adjustements to be done for this PR, thank you for the work :)
8d281cb
to
f524d3c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks ! :)
#32