-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create random integer provider #21
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b2f3fbc
to
9e35290
Compare
ff2fc14
to
3db7b68
Compare
@vianneybacoup could you please add a few lines regarding the integer provider on our docs ? 😃 |
Implement #17
3db7b68
to
529b39d
Compare
529b39d
to
6a2db8e
Compare
Done, you can review ! |
6a2db8e
to
df9f949
Compare
df9f949
to
bcf9f8a
Compare
Perfect, I merge :) |
hugues31
approved these changes
Feb 16, 2024
use yaml_rust::YamlLoader; | ||
|
||
fn generate_provider(min: Option<&str>, max: Option<&str>) -> I32Provider { | ||
let yaml_min = match min { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we could try this syntax :
let yaml_min = min.map_or(String::new(), |value| format!("\nmin: {}", value));
let yaml_max = max.map_or(String::new(), |value| format!("\nmax: {}", value));
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement #17