-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify run.sh to use redirects rather than screen #93
Conversation
to create plan and log files. /cc #92
Timely, as this project uses |
From #92 (comment):
|
I ran 3a27125 successfully in solvahol/dns. I'd like to also confirm the outputs work, and see how the Action behaves when @laszlof if you're still running |
kindof like what was done in rlespinasse/git-commit-data-action#12 /cc #94
outputs. /cc #94
and tell shellcheck not to worry about it
@solvaholic I'll give this a shot in the coming days. I've been out of town this week. Thanks for the fixes! |
Modify run.sh to use redirects, rather than screen, to create plan and log files.
Description
Currently run.sh relies on
screen
to write command exit status in its output file. This pull request replaces that with shell redirects.Motivation and Context
screen
on a given Actions runner may not write command exit status in its output file.Fixes #92
How Has This Been Tested?
Tested the redirects manually, locally, running
octodns sync
in shells of Docker containers; Pushed the code to issue92 branch and ran it in triggered workflows using solvaholic/octodns-sync@issue92.See also #92 (comment)
To-Do List
Redirect output rather than capture it with
screen
Echo comments to stdout, link to the issue
octodns sync
output as an Action outputSet it in script and update action.yml and README.md
Add a new entry for this pull request, Modify run.sh to use redirects rather than screen #93
set-output
is being deprecated #94 to handle deprecation of set-output