Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ask comment.sh not to check event type #74

Merged
merged 2 commits into from
Jul 24, 2021
Merged

Ask comment.sh not to check event type #74

merged 2 commits into from
Jul 24, 2021

Conversation

solvaholic
Copy link
Owner

Fixes #70

See also #67

@solvaholic
Document required environment
10e1b88 
in action step scripts.

Also set COMMENT_URL and working-directory in action.yml.
@solvaholic
Ask comment.sh not to check event type
a8c441e 
per #70
@solvaholic solvaholic self-assigned this Jul 24, 2021
@solvaholic
Copy link
Owner Author

I think these changes look zero-sum for folks who do not use pull_request_trigger, and all fix #70 for folks who do.

I'll go ahead and merge to main. If any serious issues arise, consider rolling back to e51df86.

@solvaholic solvaholic merged commit a4da135 into main Jul 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@solvaholic solvaholic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add_pr_comment is skipped when pull request is from fork
1 participant
@solvaholic