Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document using @peter-evans' create-or-update-comment with this Action #65

Merged
merged 3 commits into from
Jul 29, 2021

Conversation

solvaholic
Copy link
Owner

@solvaholic solvaholic commented May 11, 2021

Fixes #41

https://github.com/marketplace/actions/create-or-update-comment

@solvaholic solvaholic added the documentation Improvements or additions to documentation label May 11, 2021
@solvaholic solvaholic self-assigned this Jun 30, 2021
@solvaholic
Copy link
Owner Author

Summarize findings from #41

@solvaholic
Copy link
Owner Author

solvaholic commented Jul 4, 2021

Using @xt0rted's example as a guide and @travislikestocode's edits for #66, I stubbed out this reference config:

https://github.com/solvahol/dns/blob/850ba9cca0753de939dba41e0a05bb1bbb26ba72/.github/workflows/octodns-sync.yml

Which passed with empty payload and a fake --doit:

https://github.com/solvahol/dns/runs/2984436036?check_suite_focus=true

Demonstrate recommended configs in a public repo

Next, I think:

  • Compare solvahol/dns's octodns-sync.yml again to @xt0rted's example, see what I missed
  • Add pull_request trigger and add PR comment via create-or-update-comment
  • Either prove a safe way to trigger on pull requests from forks (see Improve comment formatting #67), or document they're not handled
    Edit: Removed this to-do item to the main issue body.

@solvaholic
Copy link
Owner Author

@solvaholic solvaholic merged commit c6233c9 into main Jul 29, 2021
@solvaholic solvaholic deleted the issue41 branch July 29, 2021 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add_pr_comment adds new comment for each run
1 participant