-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow user to specify octodns ref to run #53
Conversation
and restore the corresponding octodns-sync.sh, like in 4bca04e.
on the runner rather than in a Docker container. Removing the container image will simplify this project. 'lint' is now the only Makefile target.
and two more Docker-related files I missed earlier.
and catch up README.md
to appease the linter
and add the PR number to the changelog stub
Using this syntax I demonstrated the current version of this action a) runs and b) will update the pull request as-configured: - name: Test current configuration
id: octodns-test
uses: solvaholic/octodns-sync@issue50
with:
config_path: test-config.yaml
doit: 'no'
add_pr_comment: 'Yes'
octodns_ref: ${{ steps.pick-ref.outputs.octodns_ref }}
pr_comment_token: ${{ secrets.PAT }} So far, so good. Before merging I'll run more tests and make sure |
I'll go ahead and make v2.1.3 from be7cf5b, then merge this PR to update #57 cannot impact anyone currently using |
and learn from @haya14busa method for updating major and minor tags 🙇 https://github.com/haya14busa/action-update-semver
fix an error, add octodns_ref, try some readability changes
Description
Motivation and Context
To facilitate the request in #50, primarily.
I think moving from the Docker image to the runner scripts gives better flexibility and extensibility, and makes this action a much less complex addition to a workflow.
How Has This Been Tested?
No testing, yet.Manually, running this action@issue50
from repos holding configs.Screenshots (if appropriate):
Types of changes
Breaking change (fix or feature that would cause existing functionality to change)Checklist:
Changes
[] Update release.yml and docs/release.md(goto #55)