Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dockerfile_lint rules #37

Merged
merged 13 commits into from
Jan 18, 2021
Merged

Add dockerfile_lint rules #37

merged 13 commits into from
Jan 18, 2021

Conversation

solvaholic
Copy link
Owner

@solvaholic solvaholic commented Jan 17, 2021 •
edited
Loading

  • Add dockerfile_lint rules
  • Add Makefile lint and build targets
  • Add name, version, maintainer labels to container image
  • Run as a non-root user, or remove the rule
  • Add dockerfile_lint to linter workflow in repo
  • Teach image builders to set the version label

@solvaholic solvaholic added the enhancement New feature or request label Jan 17, 2021
@solvaholic solvaholic self-assigned this Jan 17, 2021
@solvaholic
Lint the YAML
28fcec7
@solvaholic
Add name, version, maintainer labels
077de8a 
to container image
@solvaholic
Create non-root user in image
6bcdc2d 
even though it can't run the command just yet.

entrypoint.sh will write octodns-sync output and plan to files; Need to
give the USER permission to write to them.

This commit removes the USER requirement for dockerfile_lint and makes
a few other small changes.
@solvaholic
mv .docker_lint .dockerfile_lint
46085ae
@solvaholic
Add dockerfile_lint to Lint Code Base workflow
adacc02
@solvaholic
npm install without -g
1a38502 
to accommodate permissions in runner host.
@solvaholic
Pass image version with docker build
0833c96 
and tidy up a little bit.
@solvaholic
Make IMAGE variables optional in Makefile
d3f19ba 
and remove a couple more this project won't use.
@solvaholic
Mention dockerfile_lint and labels
44c38b2 
in CHANGELOG.md
@solvaholic
Use this branch's image in action.yml
90727ee
@solvaholic
Copy link
Owner Author

Manually tested 90727ee ✅

@solvaholic solvaholic merged commit 4aec63b into main Jan 18, 2021
@solvaholic solvaholic deleted the add-make branch January 18, 2021 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@solvaholic solvaholic

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@solvaholic