-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install octodns from PyPI rather than a Git clone #28
Conversation
to include all of octodns's dependencies.
. Images built with this change have octodns installed from PyPI rather than a Git clone.
and sweep that copypasta gaffe under the rug.
Hey @solvaholic, good job on this one. If I may comment on one thing: |
Hi @barnumbirr 👋 Thank you! And thanks for bringing this up:
I'm hoping to use Dependabot to notice when While I don't plan to address
The I haven't used Dependabot or the vulnerability alerts before, so I'm prepared to change my mind once I see how they work. The tooling needs to make |
I see your point. Guess you're right in giving it a go, let's see how it pans out. |
to, hopefully, only keep up with octodns
If that Dependabot config (32755cf) works out OK I'd like to add these as well:
|
The dependency graph definitely got noisy. Dependabot seems to have only checked |
When exploring @barnumbirr suggestion in #22 to use PyPI, I realized I'd like to log all of octodns-sync dependencies in requirements.txt. That'd enable Dependabot and vulnerability scanning.
So I made the new requirements.txt like this:
Building the contents that way removed this requirement:
Installing with
pip
means the image does not need Git, so that's out - which shrank the image by about 80MB 🎉(That's a 22% reduction, which I hope will be reflected in the the runners'
docker pull
times.)