Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc fixes #9662

Merged
merged 5 commits into from
Jun 21, 2024
Merged

Doc fixes #9662

merged 5 commits into from
Jun 21, 2024

Conversation

Nadine2016
Copy link
Contributor

Description

Please include a high level summary of the changes.

This bug fixes ... \ This new feature can be used to ...

Fill out any of the following sections that are relevant and remove the others

API changes

  • Added x field to y resource
  • ...

Code changes

  • Fix error in Foo() function
  • Add Bar() function
  • ...

CI changes

  • Adjusted schedule for x job
  • ...

Docs changes

  • Added guide about feature x to public docs
  • Updated README to account for y behavior
  • ...

Context

Users ran into this bug doing ... \ Users needed this feature to ...

See slack conversation here

Interesting decisions

We chose to do things this way because ...

Testing steps

I manually verified behavior by ...

Notes for reviewers

Be sure to verify intended behavior by ...

Please proofread comments on ...

This is a complex PR and may require a huddle to discuss ...

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@Nadine2016 Nadine2016 requested a review from a team as a code owner June 21, 2024 17:50
@github-actions github-actions bot added the keep pr updated signals bulldozer to keep pr up to date with base branch label Jun 21, 2024
@Nadine2016
Copy link
Contributor Author

/skip-ci

Copy link

github-actions bot commented Jun 21, 2024

Visit the preview URL for this PR (updated for commit e3bdb7f):

https://gloo-edge--pr9662-doc-fixes-ji3nahm0.web.app

(expires Fri, 28 Jun 2024 18:53:14 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 77c2b86e287749579b7ff9cadb81e099042ef677

@soloio-bulldozer soloio-bulldozer bot merged commit 0257132 into main Jun 21, 2024
20 checks passed
@soloio-bulldozer soloio-bulldozer bot deleted the doc-fixes branch June 21, 2024 19:05
Nadine2016 added a commit that referenced this pull request Jun 21, 2024
* fix pod name

* Create doc-fixes.yaml

* Update gloo_port_reference.md

* Update gloo_port_reference.md

---------

Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com>
Nadine2016 added a commit that referenced this pull request Jun 21, 2024
* fix pod name

* Create doc-fixes.yaml

* Update gloo_port_reference.md

* Update gloo_port_reference.md

---------

Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com>
Nadine2016 added a commit that referenced this pull request Jun 21, 2024
* fix pod name

* Create doc-fixes.yaml

* Update gloo_port_reference.md

* Update gloo_port_reference.md

---------

Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com>
soloio-bulldozer bot added a commit that referenced this pull request Jun 21, 2024
* Doc fixes (#9662)

* fix pod name

* Create doc-fixes.yaml

* Update gloo_port_reference.md

* Update gloo_port_reference.md

---------

Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com>

* Rename doc-fixes.yaml to doc-fixes.yaml

---------

Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com>
soloio-bulldozer bot added a commit that referenced this pull request Jun 21, 2024
* Doc fixes (#9662)

* fix pod name

* Create doc-fixes.yaml

* Update gloo_port_reference.md

* Update gloo_port_reference.md

---------

Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com>

* Rename doc-fixes.yaml to doc-fixes.yaml

---------

Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com>
soloio-bulldozer bot added a commit that referenced this pull request Jun 21, 2024
* Doc fixes (#9662)

* fix pod name

* Create doc-fixes.yaml

* Update gloo_port_reference.md

* Update gloo_port_reference.md

---------

Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com>

* Rename doc-fixes.yaml to doc-fixes2.yaml

---------

Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keep pr updated signals bulldozer to keep pr up to date with base branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants