Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old Istio tests, add new Istio suite with regression values #9636

Merged
merged 4 commits into from
Jun 18, 2024

Conversation

npolshakova
Copy link
Contributor

Description

Cleans up old Istio regression tests. Adds regression test with old helm values to new framework.

API changes

None

Code changes

  • Removes old Istio regression tests from ci pipelines and code
  • Removes old Istio glooctl tests
  • Removes Istio installation from setup script
  • Adds a new Istio helm setup to the new framework that uses the deprecated values (enableIstioSidecarOnGateway) to check for regressions
  • Adds missing port routing test with edge apis.

CI changes

  • Removed Istio regression tests

Docs changes

None

Context

Interesting decisions

None

Testing steps

  • Validated k8s and gloo edge Istio integration tests run locally

Notes for reviewers

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@github-actions github-actions bot added the keep pr updated signals bulldozer to keep pr up to date with base branch label Jun 17, 2024
Copy link

github-actions bot commented Jun 17, 2024

Visit the preview URL for this PR (updated for commit d53df48):

https://gloo-edge--pr9636-npolshak-remove-old-n6o0mxt4.web.app

(expires Mon, 24 Jun 2024 21:56:16 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 77c2b86e287749579b7ff9cadb81e099042ef677

@npolshakova npolshakova requested a review from lgadban June 17, 2024 20:38
Copy link
Contributor

@sam-heilbron sam-heilbron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking great! Some small comments

@soloio-bulldozer soloio-bulldozer bot merged commit a0bf402 into main Jun 18, 2024
20 checks passed
@soloio-bulldozer soloio-bulldozer bot deleted the npolshak/remove-old-istio-tests branch June 18, 2024 00:34
npolshakova added a commit that referenced this pull request Jun 20, 2024
…9636)

* wip: remove old istio tests

* add regression test, add edge gw api port routing test

* pr feedback

---------

Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com>
soloio-bulldozer bot added a commit that referenced this pull request Jun 20, 2024
* Remove old Istio tests, add new Istio suite with regression values (#9636)

* wip: remove old istio tests

* add regression test, add edge gw api port routing test

* pr feedback

---------

Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com>

* move changelog

* more changelog diffs

---------

Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keep pr updated signals bulldozer to keep pr up to date with base branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants