-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.14] Expose most_specific_header_mutations wins and use append_action #8705
Merged
soloio-bulldozer
merged 8 commits into
v1.14.x
from
1.14-most-specific-header-mutations-wins-and-append-action
Sep 21, 2023
Merged
[1.14] Expose most_specific_header_mutations wins and use append_action #8705
soloio-bulldozer
merged 8 commits into
v1.14.x
from
1.14-most-specific-header-mutations-wins-and-append-action
Sep 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update header value options to convert append to envoy v3's append action * update tests to expect appendAction * remove focused test * Update append description * add changelog * add extra informatnion on header append/removal docs * Apply suggestions from code review Co-authored-by: Art <artberger@users.noreply.github.com> * Update docs/content/guides/traffic_management/request_processing/append_remove_headers/_index.md Co-authored-by: Art <artberger@users.noreply.github.com> * Update docs/content/guides/traffic_management/request_processing/append_remove_headers/_index.md Co-authored-by: Art <artberger@users.noreply.github.com> --------- Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> Co-authored-by: Art <artberger@users.noreply.github.com>
inFocus7
added
the
work in progress
signals bulldozer to keep pr open (don't auto-merge)
label
Sep 20, 2023
github-actions
bot
added
the
keep pr updated
signals bulldozer to keep pr up to date with base branch
label
Sep 20, 2023
* add most_specific_header_mutations_wins route config option * translate and add MostSpecificHeaderMutationsWins to translator_test * add changelog * add skipCI-kube-tests:true directive * add header manipulation order e2e tests and expose routeTable in testContext's testClients * codegen * Add section in docs to include mostSpecificHeaderMutationsWins * remove skipCI-kube-tests:true directive * review comment updates * Apply suggestions from code review Co-authored-by: Art <artberger@users.noreply.github.com> * review comment updates pt 2 --------- Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> Co-authored-by: Art <artberger@users.noreply.github.com>
inFocus7
commented
Sep 21, 2023
description: >- | ||
Translate header manipulation's `append` to Envoy's `append_action`, the newer non-deprecated field. | ||
skipCI-kube-tests:true | ||
- type: FIX |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FIX, as it's a backport so we can't use NEW_FEATURE, but want this change to be visible to users.
inFocus7
removed
the
work in progress
signals bulldozer to keep pr open (don't auto-merge)
label
Sep 21, 2023
artberger
approved these changes
Sep 21, 2023
davidjumani
approved these changes
Sep 21, 2023
soloio-bulldozer
bot
deleted the
1.14-most-specific-header-mutations-wins-and-append-action
branch
September 21, 2023 19:16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #8678 + #8692
Description
API/Code changes
most_specific_header_mutation_wins
in RouteConfigurations.append
translates to Envoy'sappend_action
append: true
=>append_action: APPEND_IF_EXISTS_OR_ADD
append: false
=>append_action: OVERWRITE_IF_EXISTS_OR_ADD
Docs changes
Context
Testing steps
Notice only the VS header (
VSORIGIN
) is in the headerx-frame-options
. This is because we haveappend: false
on the header, therefore it is set to overwrite any headers that came before.Edit the gateway resource to include
spec.routeOptions.mostSpecificHeaderMutationsWins: true
field.Notice that now, only the Route header (
RTORIGIN
) is in the headerx-frame-options
. This is because our route config is now set to prioritize the most specific header mutation.Notes for reviewers
Checklist: